Validate sportspress_term_order() parameter $terms

$terms can be False or WP_Error, in which case, the function will produce warnings. e.g.:

`Warning: uasort() expects parameter 1 to be array, boolean given in /var/html/wp-content/plugins/sportspress-pro/includes/sportspress/includes/sp-template-hooks.php on line 145`
This commit is contained in:
Nabil Kadimi
2018-02-14 08:40:43 +00:00
committed by GitHub
parent 87887a38aa
commit 977c63eefd

View File

@@ -141,6 +141,10 @@ function sportspress_strcmp_term_slug( $a, $b ) {
function sportspress_term_order( $terms, $post_id, $taxonomy ) {
if ( ! is_array( $terms ) ) {
return array();
}
if ( is_sp_taxonomy( $taxonomy ) ) {
uasort( $terms, 'sportspress_strcmp_term_slug' );
}
@@ -309,4 +313,4 @@ function sportspress_remove_page_parent_class( $classes, $item ) {
return $classes;
}
add_filter( 'nav_menu_css_class', 'sportspress_remove_page_parent_class', 10, 2 );
add_filter( 'nav_menu_css_class', 'sportspress_remove_page_parent_class', 10, 2 );