From 977c63eefd5c6fe0d89e6ed0d48534a03452ef75 Mon Sep 17 00:00:00 2001 From: Nabil Kadimi Date: Wed, 14 Feb 2018 08:40:43 +0000 Subject: [PATCH] Validate `sportspress_term_order()` parameter `$terms` $terms can be False or WP_Error, in which case, the function will produce warnings. e.g.: `Warning: uasort() expects parameter 1 to be array, boolean given in /var/html/wp-content/plugins/sportspress-pro/includes/sportspress/includes/sp-template-hooks.php on line 145` --- includes/sp-template-hooks.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/includes/sp-template-hooks.php b/includes/sp-template-hooks.php index f64684a0..a3d36f88 100644 --- a/includes/sp-template-hooks.php +++ b/includes/sp-template-hooks.php @@ -141,6 +141,10 @@ function sportspress_strcmp_term_slug( $a, $b ) { function sportspress_term_order( $terms, $post_id, $taxonomy ) { + if ( ! is_array( $terms ) ) { + return array(); + } + if ( is_sp_taxonomy( $taxonomy ) ) { uasort( $terms, 'sportspress_strcmp_term_slug' ); } @@ -309,4 +313,4 @@ function sportspress_remove_page_parent_class( $classes, $item ) { return $classes; } -add_filter( 'nav_menu_css_class', 'sportspress_remove_page_parent_class', 10, 2 ); \ No newline at end of file +add_filter( 'nav_menu_css_class', 'sportspress_remove_page_parent_class', 10, 2 );