Fix security and logic bugs in image generator and OG tags
- Fix null-dereference: check !$post with || before accessing post_type - Sanitize $_GET['post'] with absint() before use - Escape OG tag attribute values with esc_attr()/esc_url() Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -115,12 +115,14 @@ add_action('init', 'add_image_generator_endpoint');
|
||||
|
||||
function handle_image_request() {
|
||||
if (!isset($_GET['post'])) return;
|
||||
|
||||
$post_id = $_GET['post'];
|
||||
|
||||
$post_id = absint( $_GET['post'] );
|
||||
if ( $post_id <= 0 ) return;
|
||||
|
||||
$post = get_post($post_id);
|
||||
|
||||
// Verify post type
|
||||
if (!$post && $post->post_type !== 'sp_event') return;
|
||||
if (!$post || $post->post_type !== 'sp_event') return;
|
||||
|
||||
// Get associated teams from post meta
|
||||
$team_ids = get_post_meta($post_id, 'sp_team', false); // false to get an array of values
|
||||
|
||||
Reference in New Issue
Block a user