From e5f53035c09f8260138be5f7f187a4c808b00de3 Mon Sep 17 00:00:00 2001 From: Brian Miyaji Date: Fri, 4 May 2018 18:41:56 +1000 Subject: [PATCH] Simplify assignments hook --- .../meta-boxes/class-sp-meta-box-player-statistics.php | 1 - modules/sportspress-player-assignments.php | 8 +++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/includes/admin/post-types/meta-boxes/class-sp-meta-box-player-statistics.php b/includes/admin/post-types/meta-boxes/class-sp-meta-box-player-statistics.php index dd08c0f7..4241d574 100644 --- a/includes/admin/post-types/meta-boxes/class-sp-meta-box-player-statistics.php +++ b/includes/admin/post-types/meta-boxes/class-sp-meta-box-player-statistics.php @@ -81,7 +81,6 @@ class SP_Meta_Box_Player_Statistics { * Save meta box data */ public static function save( $post_id, $post ) { - do_action( 'sportspress_save_meta_player_statistics', $post_id, $_POST ); update_post_meta( $post_id, 'sp_leagues', sp_array_value( $_POST, 'sp_leagues', array() ) ); update_post_meta( $post_id, 'sp_statistics', sp_array_value( $_POST, 'sp_statistics', array() ) ); } diff --git a/modules/sportspress-player-assignments.php b/modules/sportspress-player-assignments.php index 39fc7098..a98ba85f 100644 --- a/modules/sportspress-player-assignments.php +++ b/modules/sportspress-player-assignments.php @@ -25,7 +25,7 @@ class SportsPress_Player_Assignments { $this->define_constants(); // Actions - add_action( 'sportspress_save_meta_player_statistics', array( $this, 'save_additional_statistics' ), 10, 2 ); + add_action( 'sportspress_process_sp_player_meta', array( $this, 'save' ) ); // Filters add_filter( 'sportspress_player_list_args', array( $this, 'add_args' ), 10 ); @@ -46,10 +46,12 @@ class SportsPress_Player_Assignments { /** * Save Additional Statistics */ - public function save_additional_statistics( $post_id, $post_data ) { + public function save( $post_id ) { delete_post_meta( $post_id, 'sp_assignments' ); - $leagues = $post_data['sp_leagues']; + $leagues = sp_array_value( $_POST, 'sp_leagues', array() ); + + if ( ! is_array( $leagues ) ) return; foreach ( $leagues as $l_id => $season ) { if ( 0 === $l_id ) continue;