From 76281155f8a71ecd33a8bfb789820e30c95acede Mon Sep 17 00:00:00 2001 From: savvasha Date: Wed, 21 Aug 2019 12:13:41 +0300 Subject: [PATCH 1/2] FIX PHP Notice: Undefined variable: key --- includes/admin/importers/class-sp-player-importer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/admin/importers/class-sp-player-importer.php b/includes/admin/importers/class-sp-player-importer.php index 353dd880..6b76ee5a 100644 --- a/includes/admin/importers/class-sp-player-importer.php +++ b/includes/admin/importers/class-sp-player-importer.php @@ -69,7 +69,7 @@ if ( class_exists( 'WP_Importer' ) ) { 'sp_season', ); foreach ( $preservable_metas_keys as $p ) { - $meta[ $key ] = ''; + $meta[ $p ] = ''; } foreach ( $columns as $index => $key ): From 30fd474554d366675a4e90c24a3b16a443d9a923 Mon Sep 17 00:00:00 2001 From: Brian Miyaji Date: Thu, 22 Aug 2019 10:16:00 +1000 Subject: [PATCH 2/2] Fix icon color picker rendering issue --- assets/css/menu.css | 2 +- assets/js/admin/iconpicker.js | 4 ++-- modules/sportspress-icons.php | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/assets/css/menu.css b/assets/css/menu.css index bd9b54af..9e11a486 100644 --- a/assets/css/menu.css +++ b/assets/css/menu.css @@ -337,7 +337,7 @@ margin: 3px 0; } -.sp-icon-color-box input[type=text] { +.sp-color-box-for-icon input[type=text] { color: #fff; } diff --git a/assets/js/admin/iconpicker.js b/assets/js/admin/iconpicker.js index 04f99c60..565e9dc1 100644 --- a/assets/js/admin/iconpicker.js +++ b/assets/js/admin/iconpicker.js @@ -23,14 +23,14 @@ jQuery(document).ready(function($){ }) .click(function(){ $('.iris-picker').hide(); - $(this).closest('.sp-icon-color-box, td').find('.iris-picker').show(); + $(this).closest('.sp-color-box-for-icon, td').find('.iris-picker').show(); }); $('body').click(function() { $('.iris-picker').hide(); }); - $('.sp-icon-color-box, .colorpick').click(function(event){ + $('.sp-color-box-for-icon, .colorpick').click(function(event){ event.stopPropagation(); }); diff --git a/modules/sportspress-icons.php b/modules/sportspress-icons.php index dec0b3be..533f5060 100644 --- a/modules/sportspress-icons.php +++ b/modules/sportspress-icons.php @@ -175,7 +175,7 @@ class SportsPress_Icons { $value = get_post_meta( $id, 'sp_color', true ); if ( empty( $value ) ) $value = '111111'; - $color = '
'; + $color = '
'; $content = '

' . __( 'Select Icon', 'sportspress' ) . '

' . $icons . '