From b488fecb4edd3ddfd29ed6035b7d6ca8f49b9e91 Mon Sep 17 00:00:00 2001 From: Nabil Kadimi Date: Wed, 12 Sep 2018 19:40:52 +0100 Subject: [PATCH 1/2] Fix location picker freezing the browser --- includes/admin/class-sp-admin-taxonomies.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/includes/admin/class-sp-admin-taxonomies.php b/includes/admin/class-sp-admin-taxonomies.php index e11b2d9a..836e8107 100644 --- a/includes/admin/class-sp-admin-taxonomies.php +++ b/includes/admin/class-sp-admin-taxonomies.php @@ -105,7 +105,9 @@ class SP_Admin_Taxonomies { $term_meta = get_option( "taxonomy_$t_id" ); $latitude = sp_array_value( $term_meta, 'sp_latitude', '40.7324319' ); $longitude = sp_array_value( $term_meta, 'sp_longitude', '-73.82480799999996' ); - else: + endif; + // Sanitize latitude and longitude + if( ! is_numeric( $latitude) || ! is_numeric( $longitude) ): $latitude = '40.7324319'; $longitude = '-73.82480799999996'; endif; @@ -147,13 +149,13 @@ class SP_Admin_Taxonomies { - + - + Date: Wed, 12 Sep 2018 19:42:56 +0100 Subject: [PATCH 2/2] Minor --- includes/admin/class-sp-admin-taxonomies.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/admin/class-sp-admin-taxonomies.php b/includes/admin/class-sp-admin-taxonomies.php index 836e8107..e2aa1343 100644 --- a/includes/admin/class-sp-admin-taxonomies.php +++ b/includes/admin/class-sp-admin-taxonomies.php @@ -106,7 +106,7 @@ class SP_Admin_Taxonomies { $latitude = sp_array_value( $term_meta, 'sp_latitude', '40.7324319' ); $longitude = sp_array_value( $term_meta, 'sp_longitude', '-73.82480799999996' ); endif; - // Sanitize latitude and longitude + // Sanitize latitude and longitude, fallback to default. if( ! is_numeric( $latitude) || ! is_numeric( $longitude) ): $latitude = '40.7324319'; $longitude = '-73.82480799999996';