From 8d5d5f9d6a898f2b7df3502fcaff5376d737240a Mon Sep 17 00:00:00 2001 From: Brian Miyaji Date: Sun, 15 Jan 2017 22:48:13 +1100 Subject: [PATCH] Stricter conditionals for overriding sport preset --- includes/admin/class-sp-admin-welcome.php | 2 +- includes/admin/settings/class-sp-settings-general.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/admin/class-sp-admin-welcome.php b/includes/admin/class-sp-admin-welcome.php index 74c56b69..98e03af7 100644 --- a/includes/admin/class-sp-admin-welcome.php +++ b/includes/admin/class-sp-admin-welcome.php @@ -335,7 +335,7 @@ class SP_Admin_Welcome { $settings = array( array( 'id' => 'sportspress_sport', - 'default' => 'custom', + 'default' => get_option( 'sportspress_sport', 'custom' ), 'type' => 'sport', 'title' => __( 'Sport', 'sportspress' ), 'welcome' => true, diff --git a/includes/admin/settings/class-sp-settings-general.php b/includes/admin/settings/class-sp-settings-general.php index 210b545c..f7afb4a6 100644 --- a/includes/admin/settings/class-sp-settings-general.php +++ b/includes/admin/settings/class-sp-settings-general.php @@ -191,7 +191,7 @@ class SP_Settings_General extends SP_Settings_Page { * Save settings */ public function save() { - if ( isset( $_POST['sportspress_sport'] ) && ! empty( $_POST['sportspress_sport'] ) && get_option( 'sportspress_sport', null ) != $_POST['sportspress_sport'] ): + if ( isset( $_POST['sportspress_sport'] ) && ! empty( $_POST['sportspress_sport'] ) && get_option( 'sportspress_sport', null ) !== $_POST['sportspress_sport'] ): $sport = $_POST['sportspress_sport']; SP_Admin_Sports::apply_preset( $sport ); update_option( '_sp_needs_welcome', 0 );