Fix Plugin-Check warnings

This commit is contained in:
Brian Miyaji
2014-01-22 04:40:30 +11:00
parent 9cde21de71
commit 76bfb6e5ee
24 changed files with 61 additions and 318 deletions

View File

@@ -1,12 +1,5 @@
<?php
function sportspress_admin_menu( $position ) {
add_options_page(
__( 'SportsPress', 'sportspress' ),
__( 'SportsPress', 'sportspress' ),
'manage_options',
'sportspress',
'sportspress_settings'
);
if ( ! current_user_can( 'manage_options' ) )
return;
@@ -23,7 +16,7 @@ function sportspress_admin_menu( $position ) {
if ( $position ):
$menu[ $position ] = array( '', 'read', 'separator-sportspress', '', 'wp-menu-separator sportspress' );
endif;
// Remove "Positions" link from Media submenu
unset( $submenu['upload.php'][17] );

View File

@@ -4,8 +4,7 @@ function sportspress_gettext( $translated_text, $untranslated_text, $domain ) {
if ( is_admin() ):
switch ( $typenow ):
case 'sp_team':
if ( 'sp_team' == $typenow ):
switch ( $untranslated_text ):
case 'Enter title here':
$translated_text = __( 'Team', 'sportspress' );
@@ -20,22 +19,7 @@ function sportspress_gettext( $translated_text, $untranslated_text, $domain ) {
$translated_text = sprintf( __( 'Remove %s', 'sportspress' ), __( 'Logo', 'sportspress' ) );
break;
endswitch;
case 'sp_event':
switch ( $untranslated_text ):
case 'Enter title here':
$translated_text = __( '(auto)', 'sportspress' );
break;
case 'Scheduled for: <b>%1$s</b>':
$translated_text = __( 'Date/Time: <b>%1$s</b>', 'sportspress' );
break;
case 'Published on: <b>%1$s</b>':
$translated_text = __( 'Date/Time: <b>%1$s</b>', 'sportspress' );
break;
case 'Publish <b>immediately</b>':
$translated_text = __( 'Date/Time: <b>%1$s</b>', 'sportspress' );
break;
endswitch;
case 'sp_player':
elseif ( in_array( $typenow, array( 'sp_event', 'sp_player', 'sp_staff' ) ) ):
switch ( $untranslated_text ):
case 'Enter title here':
$translated_text = __( 'Name', 'sportspress' );
@@ -50,41 +34,18 @@ function sportspress_gettext( $translated_text, $untranslated_text, $domain ) {
$translated_text = sprintf( __( 'Remove %s', 'sportspress' ), __( 'Photo', 'sportspress' ) );
break;
case 'Scheduled for: <b>%1$s</b>':
$translated_text = __( 'Joined: <b>%1$s</b>', 'sportspress' );
$translated_text = __( 'Date/Time: <b>%1$s</b>', 'sportspress' );
break;
case 'Published on: <b>%1$s</b>':
$translated_text = __( 'Joined: <b>%1$s</b>', 'sportspress' );
$translated_text = __( 'Date/Time: <b>%1$s</b>', 'sportspress' );
break;
case 'Publish <b>immediately</b>':
$translated_text = __( 'Joined: <b>%1$s</b>', 'sportspress' );
$translated_text = __( 'Date/Time: <b>%1$s</b>', 'sportspress' );
break;
endswitch;
case 'sp_staff':
switch ( $untranslated_text ):
case 'Enter title here':
$translated_text = __( 'Name', 'sportspress' );
break;
case 'Set featured image':
$translated_text = sprintf( __( 'Select %s', 'sportspress' ), __( 'Photo', 'sportspress' ) );
break;
case 'Set Featured Image':
$translated_text = sprintf( __( 'Select %s', 'sportspress' ), __( 'Photo', 'sportspress' ) );
break;
case 'Remove featured image':
$translated_text = sprintf( __( 'Remove %s', 'sportspress' ), __( 'Photo', 'sportspress' ) );
break;
case 'Scheduled for: <b>%1$s</b>':
$translated_text = __( 'Joined: <b>%1$s</b>', 'sportspress' );
break;
case 'Published on: <b>%1$s</b>':
$translated_text = __( 'Joined: <b>%1$s</b>', 'sportspress' );
break;
case 'Publish <b>immediately</b>':
$translated_text = __( 'Joined: <b>%1$s</b>', 'sportspress' );
break;
endswitch;
endswitch;
endif;
endif;
return $translated_text;
}
add_filter( 'gettext', 'sportspress_gettext', 20, 3 );

View File

@@ -6,7 +6,7 @@ function sportspress_manage_posts_custom_column( $column, $post_id ) {
edit_post_link( get_the_post_thumbnail( $post_id, 'sportspress-icon' ), '', '', $post_id );
break;
case 'sp_position':
echo get_the_terms( $post_id, 'sp_position' ) ? the_terms( $post_id, 'sp_position' ) : '';
echo get_the_terms( $post_id, 'sp_position' ) ? the_terms( $post_id, 'sp_position' ) : '&mdash;';
break;
case 'sp_positions':
echo get_the_terms ( $post_id, 'sp_position' ) ? the_terms( $post_id, 'sp_position' ) : sprintf( __( 'All %s', 'sportspress' ), __( 'positions', 'sportspress' ) );
@@ -15,7 +15,7 @@ function sportspress_manage_posts_custom_column( $column, $post_id ) {
$post_type = get_post_type( $post );
$teams = get_post_meta ( $post_id, 'sp_team', false );
if ( empty( $teams ) ):
echo '';
echo '&mdash;';
break;
elseif ( $post_type == 'sp_event' ):
$results = get_post_meta( $post_id, 'sp_results', true );
@@ -33,7 +33,7 @@ function sportspress_manage_posts_custom_column( $column, $post_id ) {
);
$outcomes = get_posts( $args );
echo $team->post_title . ( $outcomes ? ' ' . $outcomes[0]->post_title : '' ) . '<br>';
echo $team->post_title . ( $outcomes ? ' &mdash; ' . $outcomes[0]->post_title : '' ) . '<br>';
else:
echo $team->post_title . '<br>';
endif;
@@ -70,19 +70,19 @@ function sportspress_manage_posts_custom_column( $column, $post_id ) {
echo sportspress_the_posts( $post_id, 'sp_player' );
break;
case 'sp_event':
echo get_post_meta ( $post_id, 'sp_event' ) ? sizeof( get_post_meta ( $post_id, 'sp_event' ) ) : '';
echo get_post_meta ( $post_id, 'sp_event' ) ? sizeof( get_post_meta ( $post_id, 'sp_event' ) ) : '&mdash;';
break;
case 'sp_league':
echo get_the_terms ( $post_id, 'sp_league' ) ? the_terms( $post_id, 'sp_league' ) : '';
echo get_the_terms ( $post_id, 'sp_league' ) ? the_terms( $post_id, 'sp_league' ) : '&mdash;';
break;
case 'sp_season':
echo get_the_terms ( $post_id, 'sp_season' ) ? the_terms( $post_id, 'sp_season' ) : '';
echo get_the_terms ( $post_id, 'sp_season' ) ? the_terms( $post_id, 'sp_season' ) : '&mdash;';
break;
case 'sp_venue':
echo get_the_terms ( $post_id, 'sp_venue' ) ? the_terms( $post_id, 'sp_venue' ) : '';
echo get_the_terms ( $post_id, 'sp_venue' ) ? the_terms( $post_id, 'sp_venue' ) : '&mdash;';
break;
case 'sp_sponsor':
echo get_the_terms ( $post_id, 'sp_sponsor' ) ? the_terms( $post_id, 'sp_sponsor' ) : '';
echo get_the_terms ( $post_id, 'sp_sponsor' ) ? the_terms( $post_id, 'sp_sponsor' ) : '&mdash;';
break;
case 'sp_kickoff':
if ( $post->post_status == 'future' ):
@@ -94,10 +94,10 @@ function sportspress_manage_posts_custom_column( $column, $post_id ) {
else:
_e( 'Pending Review', 'sportspress' );
endif;
echo '<br />' . date_i18n( __( 'M j, Y @ G:i' ), strtotime( $post->post_date ) );
echo '<br />' . date_i18n( __( 'M j, Y @ G:i', 'sportspress' ), strtotime( $post->post_date ) );
break;
case 'sp_address':
echo get_post_meta( $post_id, 'sp_address', true ) ? get_post_meta( $post_id, 'sp_address', true ) : '';
echo get_post_meta( $post_id, 'sp_address', true ) ? get_post_meta( $post_id, 'sp_address', true ) : '&mdash;';
break;
endswitch;
}

View File

@@ -20,7 +20,7 @@ function sportspress_post_updated_messages( $messages ) {
$messages['post'][6] = sprintf( __( '%s published.', 'sportspress' ), $obj->labels->singular_name ) .
' <a href="' . esc_url( get_permalink($post->ID) ) . '">' . $obj->labels->view_item . '</a>';
$messages['post'][7] = sprintf( __( '%s saved.'), $obj->labels->singular_name );
$messages['post'][7] = sprintf( __( '%s saved.', 'sportspress' ), $obj->labels->singular_name );
$messages['post'][8] = sprintf( __( '%s submitted.', 'sportspress' ), $obj->labels->singular_name ) .
' <a target="_blank" href="' . esc_url( add_query_arg( 'preview', 'true', get_permalink($post->ID) ) ) . '">' .
@@ -28,7 +28,7 @@ function sportspress_post_updated_messages( $messages ) {
$messages['post'][9] = sprintf(
__( '%s scheduled for: <strong>%s</strong>.', 'sportspress' ),
date_i18n( __( 'M j, Y @ G:i' ), strtotime( $post->post_date ) ), esc_url( get_permalink($post->ID) ) ) .
date_i18n( __( 'M j, Y @ G:i', 'sportspress' ), strtotime( $post->post_date ) ), esc_url( get_permalink($post->ID) ) ) .
' <a target="_blank" href="' . esc_url( get_permalink($post->ID) ) . '">' .
sprintf( __( 'Preview %s', 'sportspress' ), $obj->labels->singular_name ) . '</a>';