From 3ea7cb6a4e9dca8fb27dc59bfff937e91305619c Mon Sep 17 00:00:00 2001
From: savvasha <savvasha@hotmail.com>
Date: Tue, 3 Oct 2023 10:40:03 +0300
Subject: [PATCH] FIX: PHP8.2.x Deprecated code warnings

---
 .../admin/class-sp-admin-permalink-settings.php    |  5 +++++
 includes/class-sp-league-table.php                 |  1 +
 includes/sp-core-functions.php                     | 14 +++++++-------
 sportspress.php                                    |  5 +++++
 4 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/includes/admin/class-sp-admin-permalink-settings.php b/includes/admin/class-sp-admin-permalink-settings.php
index f55d071c..57148223 100644
--- a/includes/admin/class-sp-admin-permalink-settings.php
+++ b/includes/admin/class-sp-admin-permalink-settings.php
@@ -19,6 +19,11 @@ if ( ! class_exists( 'SP_Admin_Permalink_Settings' ) ) :
 	 */
 	class SP_Admin_Permalink_Settings {
 
+		/**
+		 * @var array
+		 */
+		public $slugs = array();
+		
 		/**
 		 * Hook in tabs.
 		 */
diff --git a/includes/class-sp-league-table.php b/includes/class-sp-league-table.php
index 8c23fd86..3f4499ff 100644
--- a/includes/class-sp-league-table.php
+++ b/includes/class-sp-league-table.php
@@ -27,6 +27,7 @@ class SP_League_Table extends SP_Secondary_Post {
 	// ** @var strings
 	public $orderby;
 	public $orderbyorder;
+	public $compare;
 
 	/** @var int Show Published events. */
 	public $show_published_events;
diff --git a/includes/sp-core-functions.php b/includes/sp-core-functions.php
index 9ea263d4..857f8724 100644
--- a/includes/sp-core-functions.php
+++ b/includes/sp-core-functions.php
@@ -885,7 +885,7 @@ if ( ! function_exists( 'sp_dropdown_taxonomies' ) ) {
 		if ( $terms ) :
 			printf( '<select name="%s" class="postform %s" %s>', esc_attr( $name ), esc_attr( $class ) . ( $chosen ? ' chosen-select' . ( is_rtl() ? ' chosen-rtl' : '' ) : '' ), ( $placeholder != null ? 'data-placeholder="' . esc_attr( $placeholder ) . '" ' : '' ) . esc_attr( $property ) ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
 
-			if ( strpos( $property, 'multiple' ) === false ) :
+			if ( $property && strpos( $property, 'multiple' ) === false ) :
 				if ( $args['show_option_blank'] ) :
 					echo '<option value="">' . ( is_bool( $args['show_option_blank'] ) ? '' : esc_attr( $args['show_option_blank'] ) ) . '</option>';
 				endif;
@@ -898,7 +898,7 @@ if ( ! function_exists( 'sp_dropdown_taxonomies' ) ) {
 			endif;
 
 			if ( $args['show_option_auto'] ) :
-				if ( strpos( $property, 'multiple' ) !== false ) :
+				if ( $property && strpos( $property, 'multiple' ) !== false ) :
 					$selected_prop = in_array( 'auto', $selected ) ? 'selected' : '';
 				else :
 					$selected_prop = selected( 'auto', $selected, false );
@@ -914,7 +914,7 @@ if ( ! function_exists( 'sp_dropdown_taxonomies' ) ) {
 					$this_value = $term->slug;
 				endif;
 
-				if ( strpos( $property, 'multiple' ) !== false ) :
+				if ( $property && strpos( $property, 'multiple' ) !== false ) :
 					$selected_prop = in_array( $this_value, $selected ) ? 'selected' : '';
 				else :
 					$selected_prop = selected( $this_value, $selected, false );
@@ -934,7 +934,7 @@ if ( ! function_exists( 'sp_dropdown_taxonomies' ) ) {
 							$this_value = $term_child->slug;
 						endif;
 
-						if ( strpos( $property, 'multiple' ) !== false ) :
+						if ( $property && strpos( $property, 'multiple' ) !== false ) :
 							$selected_prop = in_array( $this_value, $selected ) ? 'selected' : '';
 						else :
 							$selected_prop = selected( $this_value, $selected, false );
@@ -1020,7 +1020,7 @@ if ( ! function_exists( 'sp_dropdown_pages' ) ) {
 		if ( $posts || $args['prepend_options'] || $args['append_options'] ) :
 			printf( '<select name="%s" id="%s" class="postform %s" %s>', esc_attr( $name ), esc_attr( $id ), esc_attr( $class ) . ( $chosen ? ' chosen-select' . ( is_rtl() ? ' chosen-rtl' : '' ) : '' ), ( $placeholder != null ? 'data-placeholder="' . esc_attr( $placeholder ) . '" ' : '' ) . esc_attr( $property ) ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
 
-			if ( strpos( $property, 'multiple' ) === false ) :
+			if ( $property && strpos( $property, 'multiple' ) === false ) :
 				if ( $args['show_option_blank'] ) :
 					printf( '<option value=""></option>' );
 				endif;
@@ -1046,7 +1046,7 @@ if ( ! function_exists( 'sp_dropdown_pages' ) ) {
 					$this_value = $post->post_name;
 				endif;
 
-				if ( strpos( $property, 'multiple' ) !== false ) :
+				if ( $property && strpos( $property, 'multiple' ) !== false ) :
 					$selected_prop = in_array( $this_value, $selected ) ? 'selected' : '';
 				else :
 					$selected_prop = selected( $this_value, $selected, false );
@@ -1066,7 +1066,7 @@ if ( ! function_exists( 'sp_dropdown_pages' ) ) {
 			endforeach;
 			wp_reset_postdata();
 
-			if ( strpos( $property, 'multiple' ) === false ) :
+			if ( $property && strpos( $property, 'multiple' ) === false ) :
 				if ( $args['append_options'] && is_array( $args['append_options'] ) ) :
 					foreach ( $args['append_options'] as $slug => $label ) :
 						printf( '<option value="%s" %s>%s</option>', esc_attr( $slug ), selected( $selected, $slug, false ), esc_attr( $label ) );
diff --git a/sportspress.php b/sportspress.php
index 999dd05c..9d619728 100644
--- a/sportspress.php
+++ b/sportspress.php
@@ -60,6 +60,11 @@ if ( ! class_exists( 'SportsPress' ) ) :
 		 * @var SP_Templates $templates
 		 */
 		public $templates = null;
+		
+		/**
+		 * @var SP_Feeds $feeds
+		 */
+		public $feeds = null;
 
 		/**
 		 * @var array