asc/sportspress
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make it a little bit "smarter" using jQuery to avoid default $order value

Browse Source
This commit is contained in:
savvasha
2019-03-01 18:37:04 +02:00
parent b0e3732b90
commit 1c540903cd
2 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
assets/js/admin/sportspress-admin.js
View File

@@ -886,4 +886,13 @@ jQuery(document).ready(function($){
// Trigger box score time converter // Trigger box score time converter
$('.sp-convert-time-input').change(); $('.sp-convert-time-input').change();
// Trigger show/hide of team table ordering
$('#sp_orderby').change(function(){
if ($('#sp_orderby').val() == 'default') {
$("#sp_order").hide();
}else{
$('#sp_order').show();
}
});
}); });

21
includes/admin/post-types/meta-boxes/class-sp-meta-box-table-details.php
View File

@@ -31,9 +31,6 @@ class SP_Meta_Box_Table_Details {
$date_relative = get_post_meta( $post->ID, 'sp_date_relative', true ); $date_relative = get_post_meta( $post->ID, 'sp_date_relative', true );
$orderby = get_post_meta( $post->ID, 'sp_orderby', true ); $orderby = get_post_meta( $post->ID, 'sp_orderby', true );
$order = get_post_meta( $post->ID, 'sp_order', true ); $order = get_post_meta( $post->ID, 'sp_order', true );
if ( ! $order ) {
$order = 'ASC';
}
?> ?>
<div> <div>
<p><strong><?php _e( 'Heading', 'sportspress' ); ?></strong></p> <p><strong><?php _e( 'Heading', 'sportspress' ); ?></strong></p>
@@ -111,15 +108,15 @@ class SP_Meta_Box_Table_Details {
sp_dropdown_pages( $args ); sp_dropdown_pages( $args );
?> ?>
</p> </p>
<?php if ( $orderby != 'default' ) { ?> <div id="sp_order" <?php echo ( $orderby === 'default' ? 'style="display: none;"' : '' ); ?>>
<p><strong><?php _e( 'Sort Order', 'sportspress' ); ?></strong></p> <p><strong><?php _e( 'Sort Order', 'sportspress' ); ?></strong></p>
<p> <p>
<select name="sp_order"> <select name="sp_order">
<option value="ASC" <?php selected( 'ASC', $order ); ?>><?php _e( 'Ascending', 'sportspress' ); ?></option> <option value="ASC" <?php selected( 'ASC', $order ); ?>><?php _e( 'Ascending', 'sportspress' ); ?></option>
<option value="DESC" <?php selected( 'DESC', $order ); ?>><?php _e( 'Descending', 'sportspress' ); ?></option> <option value="DESC" <?php selected( 'DESC', $order ); ?>><?php _e( 'Descending', 'sportspress' ); ?></option>
</select> </select>
</p> </p>
<?php } ?> </div>
<?php <?php
} }