From 12ab5579a9101cc8ce4fdcf5d41e7f013351a229 Mon Sep 17 00:00:00 2001 From: savvasha Date: Sun, 26 Sep 2021 16:15:04 +0300 Subject: [PATCH] FIX: PHP 8.0: Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero --- includes/class-sp-league-table.php | 2 +- includes/sp-core-functions.php | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/includes/class-sp-league-table.php b/includes/class-sp-league-table.php index 3b45a32a..ac110518 100644 --- a/includes/class-sp-league-table.php +++ b/includes/class-sp-league-table.php @@ -831,7 +831,7 @@ class SP_League_Table extends SP_Secondary_Post { // Flip value if descending order if ( $priority['order'] == 'DESC' ) $output = 0 - $output; - return ( $output > 0 ); + return ( $output > 0 ? 1 : -1 ); endif; diff --git a/includes/sp-core-functions.php b/includes/sp-core-functions.php index 2b91b7ca..03042041 100644 --- a/includes/sp-core-functions.php +++ b/includes/sp-core-functions.php @@ -1482,7 +1482,9 @@ if ( ! function_exists( 'sp_sort_terms' ) ) { $b = intval( $b ); $b = get_term( $b ); } - return get_term_meta( $a->term_id, 'sp_order', true ) > get_term_meta( $b->term_id, 'sp_order', true ); + $term_meta_a = get_term_meta( $a->term_id, 'sp_order', true ); + $term_meta_b = get_term_meta( $b->term_id, 'sp_order', true ); + return $term_meta_a == $term_meta_b ? 0 : ($term_meta_a > $term_meta_b ? 1 : -1); } }