eventlineup enhancments (availability notes, reminders, flags popup)

src/controllers/eventlineup.js

@@ -14,6 +14,22 @@ const statusCodeIcons = {
   undefined: embeddedSvgFromPath("/bootstrap-icons/question-lg.svg")
 }
 
+const statusCodeClasses = {
+  1: "u-colorPositive",
+  0: "u-colorNegative",
+  2: "u-colorPrimary",
+  null: "u-colorGrey",
+  undefined: "u-colorGrey"
+}
+
+const statusCodeButtonClasses = {
+  1: "Button--yes",
+  0: "Button--no",
+  2: "Button--maybe",
+  null: "",
+  undefined: ""
+}
+
 exports.helpers = {
   flagsString: (flags) => {
     return flags != null ? Array.from(flags).join(",") : ''
@@ -21,25 +37,8 @@ exports.helpers = {
   plus1: (i) => Number(i)+1,
   positions: () => ["P", "C", "1B", "2B", "3B", "SS", "LF", "CF", "RF", "EH", "DH", "DR"],
   defense_positions: () => ["C", "1B", "2B", "3B", "SS", "LF", "CF", "RF", "P"],
-  avail_status_code_icon: (status_code) => {
-    const icon_classes = {
-      1: "u-colorPositive",
-      0: "u-colorNegative",
-      2: "u-colorPrimary",
-      null: "u-colorGrey",
-      undefined: "u-colorGrey"
-    }
-
-    const button_classes = {
-      1: "Button--yes",
-      0: "Button--no",
-      2: "Button--maybe",
-      null: "",
-      undefined: ""
-    }
-
-    return `<button class="Button Button--smallSquare ${button_classes[status_code]}" type="button"><span class="">${statusCodeIcons[status_code]}</span></button>`
-  },
+  avail_status_code_class: (status_code) => statusCodeButtonClasses[status_code],
+  avail_status_code_icon: (status_code) => statusCodeIcons[status_code],
   positionLabelWithoutFlags: (label) => {
     const {positionLabelWithoutFlags} = parsePositionLabel(label);
     return positionLabelWithoutFlags
@@ -92,6 +91,12 @@ exports.helpers = {
     statusShortLookup[NONE] = "UNK"
     statusShortLookup[undefined] = "UNK"
     return (statusShortLookup[availability?.statusCode])
+  },
+  filterNonPlayers: (members) => {
+    return members.filter(m=>!m.isNonPlayer)
+  },
+  joinMemberEmailAddresses: (members) => {
+    return members.map(m=>m.emailAddresses.join(',')).join(',')
   }
 }
 
@@ -121,9 +126,13 @@ exports.getAdjacentEventLineup = async (req, res) => {
   } else {
     throw new Error('Index must be positive or negative number')
   }
+  if (!event) {
+    res.status(500).send()
+    return
+  }
   const availabilitySummary = event.availabilitySummary
   const event_lineup = req.timeline.event_lineups.find(i=>i.eventId==event.id)
-  const event_lineup_entries = req.timeline.event_lineup_entries.filter(i=>i.eventId==event.id)
+  const event_lineup_entries = req.timeline.event_lineup_entries?.filter(i=>i.eventId==event.id)
   const availabilities = req.timeline.availabilities.filter(i=>i.eventId==event.id)
   attachBenchcoachPropertiesToMember(members, event_lineup_entries, availabilities)
   members.sort(tsUtils.teamsnapMembersSortLineupAvailabilityLastName)
@@ -142,7 +151,7 @@ attachBenchcoachPropertiesToMember = (members, event_lineup_entries, availabilit
     // as far as I can tell, member_name should consistently be formulated from first and last name
     // perhaps could have some edge cases if first or last names change, but this *should be* exceedingly rare.
     const member_name = `${member.firstName} ${member.lastName}`
-    const event_lineup_entry = event_lineup_entries.find(e=> e.memberId == member.id || e.memberName == member_name)
+    const event_lineup_entry = event_lineup_entries?.find(e=> e.memberId == member.id || e.memberName == member_name)
     const availability = availabilities.find(e=>e.memberId == member.id)
     member.benchcoach.availability = availability
     if (event_lineup_entry != null) {