Consolidated Edit View

players/urls.py

@@ -1,13 +1,12 @@
 from django.urls import path, include
 
-from .views import PlayerListView
+from .views import PlayerListView, PlayerEditView
 
 from . import views
 
 urlpatterns = [
     path('', views.root, name="root"),
-    # path('list', views.list, name="players list"),
     path('list', PlayerListView.as_view(), name='players list'),
-    path('edit/<int:id>', views.edit, name="edit player"),
-    path('edit', views.edit, name="edit player")
+    path('edit/<int:id>', PlayerEditView.as_view(), name="edit player"),
+    path('edit', PlayerEditView.as_view(), name="edit player")
 ]

players/views.py

@@ -4,7 +4,7 @@ from django.http import HttpResponse
 from django.urls import reverse
 from .models import Player
 from .forms import PlayerForm
-from lib.views import BenchcoachListView
+from lib.views import BenchcoachListView, BenchcoachEditView
 
 # Create your views here.
 
@@ -19,30 +19,8 @@ class PlayerListView(BenchcoachListView):
 def root(request):
     return redirect('/players/list')
 
-def edit(request, id=0):
-    # if this is a POST request we need to process the form data
-    if request.method == 'POST':
-        # create a form instance and populate it with data from the request:
-        if id:
-            instance = get_object_or_404(Player, id=id)
-            form = PlayerForm(request.POST or None, instance=instance)
-        else:
-            form = PlayerForm(request.POST or None)
-        # check whether it's valid:
-        if form.is_valid():
-            # process the data in form.cleaned_data as required
-            if id == 0: id = None
-            new_player, did_create = Player.objects.update_or_create(pk=id, defaults=form.cleaned_data)
-            return render(request, 'success.html', {'call_back':reverse('players list'),'id':new_player.id}, status=201 if did_create else 200)
-        else:
-            return HttpResponse(status=400)
-
-    # if a GET (or any other method) we'll create a blank form
-    else:
-        if id:
-            instance = get_object_or_404(Player, id=id)
-            form = PlayerForm(request.POST or None, instance=instance)
-        else:
-            form = PlayerForm
-
-    return render(request, 'edit.html', {'form': form, 'id': id, 'call_back':'edit player'})
+class PlayerEditView(BenchcoachEditView):
+    Form = PlayerForm
+    Model = Player
+    edit_url = 'edit player'
+    list_url = 'players list'