From a9ba4f27ff02b345522f950c18fdfdbfb335d4d6 Mon Sep 17 00:00:00 2001
From: Anthony Correa
Date: Thu, 23 Jan 2025 07:50:19 -0600
Subject: [PATCH] Refactor debug mode initialization and settings management
- Replaced the "enableFeature" setting with "enableDebugMode" for clarity.
- Added a new `requiresReload` property for the debug mode setting.
- Updated the default value to `false` and refined the hint text.
- Removed unused "theme" setting from `settings.js`.
- Enhanced the `init` hook in `main.js` to properly configure debug mode:
- Logs a message when debug mode is enabled.
- Sets `CONFIG.debug.hooks` conditionally based on the debug mode setting.
- Minor adjustments for consistency in code formatting and logging.
These changes improve the debugging experience and streamline module settings.
Update module title and bump version to 0.1.1
- Changed module title from "asc-asset-manager" to "Asset Manager" for a more user-friendly name.
- Updated the version in `module.json` from `0.1.0` to `0.1.1` to reflect the update.
Add download and manifest URLs and update compatibility version
- Added `download` and `manifest` URLs to `module.json`:
- `download`: Points to the module's ZIP file for version `0.1.1`.
- `manifest`: Points to the latest release manifest file.
- Updated the `verified` compatibility version from `12` to `12.331` to ensure compatibility with the latest framework version.
Fix download URL in module.json
Updated the `download` URL in `module.json` to correctly point to the `0.1.1` release ZIP file under the `/releases/download/0.1.1/` path.
---
src/main.js | 13 +++++++++++--
src/module.json | 8 +++++---
src/settings.js | 29 ++++++-----------------------
3 files changed, 22 insertions(+), 28 deletions(-)
diff --git a/src/main.js b/src/main.js
index 2277bc3..ac360fd 100644
--- a/src/main.js
+++ b/src/main.js
@@ -35,11 +35,20 @@ export class AscAssetManager {
}
}
-Hooks.on('init', ()=>CONFIG.debug.hooks = true)
+Hooks.on('init', ()=>{
+
+ }
+)
Hooks.on("ready", function() {
- AscAssetManager.log(false, "Deno nodule reody")
registerSettings(AscAssetManager);
+ const DEBUG = game.settings.get(AscAssetManager.ID, "enableDebugMode")
+ if (DEBUG) {
+ AscAssetManager.log(false, "Debug Mode Enabled")
+ CONFIG.debug.hooks = true
+ }
+ AscAssetManager.log(false, "Deno nodule reody")
+
});
Hooks.on("ascAssetManager.renderUploadChoose", (data={}) => {
diff --git a/src/module.json b/src/module.json
index 1f48002..3219f65 100644
--- a/src/module.json
+++ b/src/module.json
@@ -1,10 +1,12 @@
{
"id": "asc-asset-manager",
- "title": "asc-asset-manager",
- "version": "0.1.0",
+ "title": "Asset Manager",
+ "version": "0.1.1",
+ "download": "https://gitea.ascorrea.com/asc/asc-asset-manager/releases/download/0.1.1/module.zip",
+ "manifest": "https://gitea.ascorrea.com/asc/asc-asset-manager/releases/download/latest/module.json",
"compatibility": {
"minimum": "12",
- "verified": "12"
+ "verified": "12.331"
},
"authors": [
{
diff --git a/src/settings.js b/src/settings.js
index d8d9533..76c3561 100644
--- a/src/settings.js
+++ b/src/settings.js
@@ -3,15 +3,16 @@ export function registerSettings(AscAssetManager) {
const ID = AscAssetManager.ID
//Ability
// Register the "enableFeature" setting
- game.settings.register(ID, "enableFeature", {
- name: "Enable Feature",
- hint: "Enable or disable the special feature of this module.",
+ game.settings.register(ID, "enableDebugMode", {
+ name: "Enable Debug Mode",
+ hint: "Enable or disable debug mode for this module. When enabled, additional debugging information will be logged to the console.",
scope: "world",
config: true,
type: Boolean,
- default: true,
+ requiresReload: true,
+ default: false,
onChange: value => {
- console.log(`Enable Feature setting changed to: ${value}`);
+ console.log(`Debug Mode setting changed to: ${value}`);
}
});
@@ -29,24 +30,6 @@ export function registerSettings(AscAssetManager) {
}
});
- // Register a dropdown setting
- game.settings.register(ID, "theme", {
- name: "Select Theme",
- hint: "Choose a theme for the module.",
- scope: "world",
- config: true,
- type: String,
- choices: {
- light: "Light Theme",
- dark: "Dark Theme",
- system: "Use System Default"
- },
- default: "system",
- onChange: value => {
- console.log(`Theme changed to: ${value}`);
- }
- });
-
game.settings.registerMenu(ID, "instructions", {
name: "Add macro to hotbar",
label: "Get Macro",